feat(datepicker): focustrap for popup datepickers #2332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Apparently, tests are failing on IE10 |
Closed
maxokorokov
force-pushed
the
datepicker-focustrap
branch
from
43f629b
to
e096623
Compare
maxokorokov
approved these changes
Apr 27, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Straight forward implementation of focustrap for any datepicker opened in a popup via
NgbDatepickerInputThis PR does not have any tests, as writing UT for that would end up in duplicating NgbFocusTrap UT.
Nonetheless, as soon as Protractor is setup on the project, we then can write a whole bunch of new dedicated tests.