fix(datepicker): prevent focustrap to restore focus on destroy #2392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benouat
changed the title
| @@ -48,7 +48,7 @@ describe('ngbFocusTrap', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| it('should save/restore focused element when autofocus is set', () => { | |||
| it('should focus element decorated with ngbAutofocus when created', () => { | |||
There was a problem hiding this comment.
Is this tests truly verifies what it claims? I can't see any element with ngbAutofocus anywhere....
There was a problem hiding this comment.
Here it is line 84 of the same file
https://github.com/benouat/ng-bootstrap/blob/9c946f70d9fd382ea1386233c7fa85ad661ec01d/src/util/focus-trap.spec.ts#L84
There was a problem hiding this comment.
Oh, right, I see. But still, we should have an expectation verifying that this element is actually focused, no?
There was a problem hiding this comment.
Never mind, it was just GitHub diff view not showing the whole test :-/ LGTM
|
@benouat I think that tests need more attention - left an in-line comment. |
|
LGTM, going to merge in a bit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this fix, focustrap on datepicker will no longer remember element focused prior initialization, and thus won't try to set it back on destroy.
fixes #2372