New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datepicker): close datepicker popup on ESC from anywhere #2432

Merged

maxokorokov merged 1 commit into ng-bootstrap:master from maxokorokov:datepicker/feat/close-on-esc

Jun 7, 2018

Member

maxokorokov commented Jun 4, 2018

sets up handlers when datepicker is open
removes handlers when datepicker closes
listens on the document, not on the input


          feat(datepicker): close datepicker popup on ESC from anywhere

dd733f8

maxokorokov added needs: review component: datepicker labels

maxokorokov added this to the 2.1.0 milestone

benouat approved these changes

View reviewed changes

maxokorokov removed the needs: review label

maxokorokov merged commit 2666d8b into ng-bootstrap:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment