fix(datepicker): empty month select box when displayMonths > 1 #2452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The list of months and years was generated from the focused date rather than the first displayed date, which was inconsistent with the value used in the datepicker navigation component, which uses the first displayed date. This inconsistency was not visible when displayMonths = 1 but it sometimes caused the following issue when several months were displayed: the month select box was empty as it did not contain the currently displayed month. Closes ng-bootstrap#2377
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The list of months and years was generated from the focused date rather than the first displayed date, which was inconsistent with the value used in the datepicker navigation component, which uses the first displayed date.
This inconsistency was not visible when displayMonths = 1 but it sometimes caused the following issue when several months were displayed: the month select box was empty as it did not contain the currently displayed month.
Closes #2377