New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(live): use a single DOM element for Live Announcer #2458

Closed

maxokorokov wants to merge 1 commit into ng-bootstrap:master from maxokorokov:live/fix/single-dom-element

Member

maxokorokov commented Jun 15, 2018

An attempt to lazily create and reuse aria-live element for the live announcer

test execution order doesn't matter anymore
multiple ng-bootstrap modules will use a single DOM element
ARIA_LIVE_DELAY_TYPE → any for SSR


          fix(live): use a single DOM element for Live Announcer

d06aca9

maxokorokov added the needs: review label

maxokorokov added this to the 2.1.1 milestone

Member

pkozlowski-opensource commented Jun 15, 2018

LGTM

pkozlowski-opensource closed this in

31968ad

maxokorokov mentioned this pull request

typeahead adds <div aria-live> element to body but does not remove it #2457

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment