Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(progressbar): add missing i18n id specifier #2493

Conversation

markpeterfejes
Copy link
Contributor

The id was picked up as description by the angular cli, which resulted in a random id:

<trans-unit id="04d611d19c117c60c9e14d0a04399a027184bc77" datatype="html">
    <source><x id="INTERPOLATION" equiv-text="{{getPercentValue()}}"/>%</source>
    <context-group purpose="location">
      <context context-type="sourcefile">../node_modules/@ng-bootstrap/ng-bootstrap/progressbar/progressbar.d.ts</context>
      <context context-type="linenumber">6</context>
    </context-group>
    <note priority="1" from="description">ngb.progressbar.value</note>
</trans-unit>

The id was picked up as description by the angular cli, which resulted in a random id.
@maxokorokov maxokorokov added this to the 3.0.0 milestone Jul 3, 2018
Copy link
Member

@maxokorokov maxokorokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

pkozlowski-opensource pushed a commit that referenced this pull request Jul 27, 2018
The id was picked up as description by the angular cli, which resulted in a random id.

Closes #2493
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants