fix(accordion): the markup should follow the boostrap one #2511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benouat
requested changes
Jul 12, 2018
| class="card-body collapse" [class.show]="panel.isOpen" *ngIf="!destroyOnHide || panel.isOpen"> | ||
| <ng-template [ngTemplateOutlet]="panel.contentTpl?.templateRef"></ng-template> | ||
| class="collapse" [class.show]="panel.isOpen" *ngIf="!destroyOnHide || panel.isOpen"> | ||
| <div class="card-body"> |
There was a problem hiding this comment.
I think we are also missing card on here
From BS demo site
<div class="collapse" id="collapseExample">
<div class="card card-body">
Anim pariatur cliche reprehenderit, enim eiusmod high life accusamus terry richardson ad squid. Nihil anim keffiyeh helvetica, craft beer labore wes anderson cred nesciunt sapiente ea proident.
</div>
</div>There was a problem hiding this comment.
Nevermind, I overlooked it. card and card-body on the same element is for just a single collpase.
maxokorokov
approved these changes
Jul 12, 2018
There was a problem hiding this comment.
LGTM!
It's the missing part of the #2368. I guess it should have been a breaking change though... not sure about this one, @pkozlowski-opensource, WDYT?
|
@maxokorokov I would consider this a fix. Merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the bootstrap example: https://getbootstrap.com/docs/4.1/components/collapse/#accordion-example
The card-body is inside the collapse element. It can be useful for animation.