Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dropdown): close dropdown correctly inside the OnPush component #2561

Merged
merged 1 commit into from
Jul 31, 2018
Merged

fix(dropdown): close dropdown correctly inside the OnPush component #2561

merged 1 commit into from
Jul 31, 2018

Conversation

maxokorokov
Copy link
Member

  • fixes a regression introduced in 2.2.1: click handler didn't mark component as dirty
  • cleans up click handler correctly
  • removes unnecessary checks in tests

Fixes #2559

@maxokorokov maxokorokov added this to the 2.2.2 milestone Jul 31, 2018
@maxokorokov
fix(dropdown): close dropdown correctly inside the OnPush component
619b36e 
Fixes a regression introduced in 2.2.1: click handler didn't mark component as dirty

Fixes ng-bootstrap#2559
@maxokorokov maxokorokov modified the milestones: 2.2.2, 3.0.0 Jul 31, 2018
@maxokorokov
Copy link
Member Author

Should be released in 2.2.2 and 3.0.0

@pkozlowski-opensource
Copy link
Member

LGTM. Feel free to merge.

@maxokorokov maxokorokov merged commit a2dea82 into ng-bootstrap:master Jul 31, 2018
pkozlowski-opensource pushed a commit that referenced this pull request Aug 3, 2018
@maxokorokov @pkozlowski-opensource
fix(dropdown): close dropdown correctly inside the OnPush component
75060ca 
Fixes a regression introduced in 2.2.1: click handler didn't mark component as dirty

Closes #2561
Fixes #2559
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: dropdown
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

(regression from 2.2.0): ngbDropdownMenu does not disappear when clicked if ChangeDetectionStrategy.OnPush
2 participants
@maxokorokov @pkozlowski-opensource