Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tabset): allow arbitrary nav type #2592

Merged
merged 1 commit into from
Aug 10, 2018
Merged

feat(tabset): allow arbitrary nav type #2592

merged 1 commit into from
Aug 10, 2018

Conversation

pkozlowski-opensource
Copy link
Member

Alternative to #1661

@pkozlowski-opensource pkozlowski-opensource mentioned this pull request Aug 10, 2018
Closed
@pkozlowski-opensource pkozlowski-opensource added this to the 3.1.0 milestone Aug 10, 2018
maxokorokov
maxokorokov approved these changes Aug 10, 2018
View reviewed changes
Copy link
Member

@maxokorokov maxokorokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkozlowski-opensource pkozlowski-opensource merged commit 1e68401 into ng-bootstrap:master Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxokorokov maxokorokov maxokorokov approved these changes

Assignees
No one assigned
Labels
component: tab needs: merging
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pkozlowski-opensource @maxokorokov