Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tooltip): ability to add custom CSS classes to tooltip window #2625

Merged
merged 1 commit into from
Aug 28, 2018

Conversation

divdavem
Copy link
Member

This PR implements the feature requested in #1349, and as @pkozlowski-opensource suggested, it is almost exactly a copy of what was done for popovers in 483bd05.

Before submitting a pull request, please make sure you have at least performed the following:

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated any applicable tests.
  • added/updated any applicable API documentation.
  • added/updated any applicable demos.

Copy link
Member

@benouat benouat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@divdavem
Copy link
Member Author

@benouat Thank you for your review!

@pkozlowski-opensource pkozlowski-opensource modified the milestones: 3.2.0, 3.1.0 Aug 24, 2018
@pkozlowski-opensource
Copy link
Member

@divdavem I'm sorry but I've just merged a PR from @benouat that was waiting in the queue for quite some time :-/ As a result your PR needs rebase now as we are using a new structure for demos, see fd76e4b

Could you please rebase (talk to @benouat if you need help).

@divdavem
Copy link
Member Author

@pkozlowski-opensource I have rebased the PR.

@benouat benouat merged commit 709d6b6 into ng-bootstrap:master Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants