feature(date-picker): added aria-labels to year and month select elem…

[RonnBlack]

…ents

Before submitting a pull request, please make sure you have at least performed the following:

• [] read and followed the CONTRIBUTING.md guide.
• [] built and tested the changes locally.
• [] added/updated any applicable tests.
• [] added/updated any applicable API documentation.
• [] added/updated any applicable demos.

[pkozlowski-opensource]

@RonnBlack based on the discussion in #2543 it doesn't seem like aria labels alone are enough...
Did you tests with screen readers and found different results in your testing?

[rblack-a3digital]

Thanks for pointing out the discussion. I hadn't seen this.
I was only basing my changes on recommendations from WAVE (Web Accessibility Evaluation Tool) and I didn't actually test with a screen reader. I'll update the code to add the title property and update the pull request.

[pkozlowski-opensource]

. I'll update the code to add the title property and update the pull request.

To be frank we are still unsure if adding this property is the right thing to do as it will have visual impact. We need more solid testing with different screen readers.

[RonnBlack]

I added titles to the select elements and tested in Chrome, Firefox, and Edge. I saw no display issues on Windows 10 or Mac OS High Sierra (10.13.6). You mentioned that there would be visual impact... do you know of something specific?

I also tested with Voice Over on Mac and Narrator on Windows and the drop downs seemed to behave as I would expect. It looks like the pull request shows the additional changes I made. If that isn't the case let me know.

[benouat]

You mentioned that there would be visual impact... do you know of something specific?

I think @pkozlowski-opensource was mentioning the fact that browsers add a native native yellow tooltip on elements with title attribute when you hover them and wait for some milliseconds.

[RonnBlack]

Yes the hover behavior is there but the next and previous month buttons also have that behavior.
In my testing with screen readers it seemed to work fine with just the aria-label even before I added the title. The only problem I noticed is that the Microsoft Narrator didn't announce the label on the Month select but it did properly announce it on the Year. Once title was added it was fine with both. Mac Voice over didn't have a problem either way but IMHO the way it announced what you were on was more confusing (perhaps there is some control over this)

[maxokorokov]

It actually doesn't shock me to have titles on select boxes and we already have them on previous/next arrows.

Thanks, @RonnBlack !