fix(datepicker): no longer trigger onChange when the value is equivalent #2668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divdavem
force-pushed
the
datepickerRealOnChange
branch
from
acaf6e9
to
a5a509b
Compare
maxokorokov
reviewed
Sep 13, 2018
| @@ -149,6 +149,7 @@ export class NgbDatepicker implements OnDestroy, | |||
| OnChanges, OnInit, ControlValueAccessor { | |||
| model: DatepickerViewModel; | |||
|
|
|||
| private _controlValue: NgbDate; | |||
There was a problem hiding this comment.
Do you mind if we move this to the datepicker service?
Not sure it it makes a huge difference, but the idea was to keep any state away from component.
I would have added an option:
this._service.select(..., {fromControl: true});in this case the service's select would to something like:
if (isChangedDate(this._state.selectedDate, selectedDate)) {
this._nextState({selectedDate, controlValue: options.fromControl ? selectedDate : undefined});
}P.S. names formControl and controlValue are just examples
There was a problem hiding this comment.
Thank you for your comment! It is a good idea! I will update my PR.
There was a problem hiding this comment.
Well, in fact, as discussed, I think it is better as it is now (as we need to update controlValue again when calling onChange).
There was a problem hiding this comment.
Yep, as discussed, simpler to leave it as is
|
@maxokorokov Thank you for your review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting a pull request, please make sure you have at least performed the following: