feat(modal): implicit context for template based modal #2669

benouat · 2018-08-30T13:37:27Z

Any template based modal should now be using implicit context

Before:

<ng-template #content let-c="close" let-d="dismiss">
  <!-- ... -->
  <button (click)="c('closing')">Close</button>
  <button (click)="d('dismiss')">Dismiss</button>
  <!-- ... -->
</ng-template>

After:

<ng-template #content let-modal>
  <!-- ... -->
  <button (click)="modal.close('closing')">Close</button>
  <button (click)="modal.dismiss('dismiss')">Dismiss</button>
  <!-- ... -->
</ng-template>

pkozlowski-opensource · 2018-08-30T13:45:07Z

src/modal/modal-stack.ts

@@ -132,7 +131,9 @@ export class NgbModalStack {
  }

  private _createFromTemplateRef(content: TemplateRef<any>, context: NgbActiveModal): ContentRef {
-    const viewRef = content.createEmbeddedView(context);
+    const $context =
+        {$implicit: context, close(result) { context.close(result); }, dismiss(reason) { context.dismiss(reason); }};


Could you please rename:

context => activeModal

$context => tplRefContext / context

pkozlowski-opensource · 2018-08-30T13:45:27Z

src/modal/modal.spec.ts

@@ -26,7 +26,7 @@ class CustomSpyService {
  called = false;
 }

-describe('ngb-modal', () => {
+fdescribe('ngb-modal', () => {


fdescribe

benouat changed the title ~~fix(modal): implicit context for template based~~ fix(modal): implicit context for template based modal Aug 30, 2018

pkozlowski-opensource reviewed Aug 30, 2018

View reviewed changes

benouat force-pushed the fix/modal-template-context branch from 702beed to 36527df Compare August 30, 2018 13:51

feat(modal): implicit context for template based

36527df

benouat changed the title ~~fix(modal): implicit context for template based modal~~ feat(modal): implicit context for template based modal Aug 30, 2018

pkozlowski-opensource closed this in 6e4f9e7 Aug 30, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(modal): implicit context for template based modal #2669

feat(modal): implicit context for template based modal #2669

benouat commented Aug 30, 2018

pkozlowski-opensource Aug 30, 2018

benouat Aug 30, 2018

pkozlowski-opensource Aug 30, 2018

benouat Aug 30, 2018

feat(modal): implicit context for template based modal #2669

feat(modal): implicit context for template based modal #2669

Conversation

benouat commented Aug 30, 2018

pkozlowski-opensource Aug 30, 2018

Choose a reason for hiding this comment

benouat Aug 30, 2018

Choose a reason for hiding this comment

pkozlowski-opensource Aug 30, 2018

Choose a reason for hiding this comment

benouat Aug 30, 2018

Choose a reason for hiding this comment