feat(modal): allow checking if there are open modals #2740
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benouat
approved these changes
Sep 24, 2018
src/modal/modal.ts
Outdated
| /** | ||
| * Indicates if there are currently any open modal windows in the application. | ||
| */ | ||
| hasOpenWindows(): boolean { return this._modalStack.hasOpenWindows(); } |
There was a problem hiding this comment.
Some nitpicking here, but I would have named it hasOpenModals()
Even your commit message is using open modals and not windows
There was a problem hiding this comment.
Ok, thnx, will change it to hasOpenModals()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1600
A tiny PR for a good start of the weekend!