feat(widgets): turn on viewEncapsulation.None #2784
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxokorokov
requested changes
Oct 11, 2018
| @@ -1,4 +1,4 @@ | |||
| :host>select { | |||
| ngb-datepicker-navigation-select > select { | |||
There was a problem hiding this comment.
this should be more specific without encapsulation, ex:
ngb-datepicker-navigation-select > .custom-select
maxokorokov
reviewed
Oct 12, 2018
src/tooltip/tooltip.scss
Outdated
| :host { | ||
| &.bs-tooltip-top .arrow, | ||
| &.bs-tooltip-bottom .arrow { | ||
| .bs-tooltip { |
There was a problem hiding this comment.
I guess it should be specific to ngb-popover-window, not to any .bs-tooltip
maxokorokov
reviewed
Oct 12, 2018
src/popover/popover.scss
Outdated
| :host { | ||
| &.bs-popover-top .arrow, | ||
| &.bs-popover-bottom .arrow { | ||
| .bs-popover { |
There was a problem hiding this comment.
I guess it should be specific to ngb-popover-window, not to any .bs-popover
fbasso
force-pushed
the
viewEncapsulation
branch
from
60ee686
to
547a8d5
Compare
|
Thanks for the review ! The changes have been done. |
maxokorokov
approved these changes
Oct 12, 2018
|
@fbasso I know it's really some extreme nitpicking here, but we should rewrite the commit message whenever merging this PR to turning off ViewEncapsulation It sounds clearer to me from a git history purpose |
fbasso
force-pushed
the
viewEncapsulation
branch
from
547a8d5
to
e9aab53
Compare
fbasso
force-pushed
the
viewEncapsulation
branch
from
e9aab53
to
8d2d2a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this PR is to allow a better widgets customization with css.