New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(modal): focus stays trapped with Shift+Tab #2807

Merged

maxokorokov merged 1 commit into ng-bootstrap:master from maxokorokov:modal/fix/shift-tab-focus-trap

Oct 18, 2018

Member

maxokorokov commented Oct 17, 2018

Fixes #2718


          fix(modal): focus stays trapped with Shift+Tab

b0ced50

Fixes ng-bootstrap#2718

maxokorokov added component: modal needs: review type: bug labels

maxokorokov added this to the 3.3.1 milestone

benouat approved these changes

View reviewed changes

Member

benouat commented Oct 18, 2018 •

edited

LGTM, you can go ahead and merge as soon as travis is green (I relaunched it, it timed out)

maxokorokov removed the needs: review label

maxokorokov merged commit 67651be into ng-bootstrap:master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment