-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(timepicker): use Angular locale data for AM and PM #2830
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please have a look at my comment ?
Codecov Report
@@ Coverage Diff @@
## master #2830 +/- ##
==========================================
+ Coverage 92.25% 92.27% +0.02%
==========================================
Files 91 92 +1
Lines 3009 3018 +9
Branches 484 485 +1
==========================================
+ Hits 2776 2785 +9
Misses 171 171
Partials 62 62
Continue to review full report at Codecov.
|
Sorry, will have to move this to |
Hey @reduckted would you mind rebasing this PR in order to land it in |
Hi @benouat, I've just rebased onto master. Thanks for taking a look :) |
Fixes #2822.
Before submitting a pull request, please make sure you have at least performed the following: