Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(timepicker): use Angular locale data for AM and PM #2830

Merged
merged 1 commit into from
Jun 28, 2019
Merged

feat(timepicker): use Angular locale data for AM and PM #2830

merged 1 commit into from
Jun 28, 2019

Conversation

reduckted
Copy link
Contributor

@reduckted reduckted commented Oct 26, 2018

Fixes #2822.

Before submitting a pull request, please make sure you have at least performed the following:

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated any applicable tests.
  • added/updated any applicable API documentation.
  • added/updated any applicable demos.

Copy link
Member

@benouat benouat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please have a look at my comment ?

src/timepicker/timepicker.ts Outdated Show resolved Hide resolved
@benouat benouat added this to the 4.0.1 milestone Nov 8, 2018
@pkozlowski-opensource pkozlowski-opensource removed this from the 4.0.1 milestone Nov 22, 2018
@benouat benouat added this to the 4.1 milestone Nov 28, 2018
@codecov-io
Copy link

codecov-io commented Dec 24, 2018

Codecov Report

Merging #2830 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2830      +/-   ##
==========================================
+ Coverage   92.25%   92.27%   +0.02%     
==========================================
  Files          91       92       +1     
  Lines        3009     3018       +9     
  Branches      484      485       +1     
==========================================
+ Hits         2776     2785       +9     
  Misses        171      171              
  Partials       62       62
Flag Coverage Δ
#e2e 60.76% <60%> (+0.01%) ⬆️
#unit 90.77% <100%> (+0.02%) ⬆️
Impacted Files Coverage Δ
src/index.ts 100% <ø> (ø) ⬆️
src/timepicker/timepicker.module.ts 100% <ø> (ø) ⬆️
src/timepicker/timepicker.ts 98.8% <100%> (ø) ⬆️
src/timepicker/timepicker-i18n.ts 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3f65ac8...5f7dfbe. Read the comment docs.

@maxokorokov
Copy link
Member

Sorry, will have to move this to 5.0.0 as technically might be a breaking change for those using non-default locale in their applications

@benouat
Copy link
Member

benouat commented Jun 24, 2019

Hey @reduckted would you mind rebasing this PR in order to land it in 5.0.0 as soon as 5.0.0-rc.0 is built ?

@reduckted
Copy link
Contributor Author

Hi @benouat, I've just rebased onto master. Thanks for taking a look :)

@pkozlowski-opensource pkozlowski-opensource modified the milestones: 5.0, 5.0.0-rc.1 Jun 28, 2019
@benouat benouat merged commit 3ce8a4c into ng-bootstrap:master Jun 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: TimePicker should use Angular's i18n data to get meridian names
5 participants