fix(focustrap): discarding tabindex='-1' when finding element #2888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxokorokov
approved these changes
Nov 28, 2018
| <button class="other">Other button</button> | ||
| ` | ||
| }) | ||
| export class WithSkipTabindexFirstFocusableModalCmpt { |
There was a problem hiding this comment.
Good naming! Though, could you change to WithNegativeTabIndexElementThatShouldBeSkippedWhileFindingFirstFocusableElementModalComponent?
Just kidding :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When focus-trap needs to figure out what are the boundaries elements (first and last focusable elements) we need to perform an extra check to filter out elements with
tabindex="-1"Closes #2884