fix(timepicker): setting hour/minute/second step to undefined #2903
Conversation
src/timepicker/timepicker.ts
Outdated
| @@ -96,6 +96,10 @@ export class NgbTimepicker implements ControlValueAccessor, | |||
| disabled: boolean; | |||
| model: NgbTime; | |||
|
|
|||
| private _hourStep; | |||
src/timepicker/timepicker.ts
Outdated
| @@ -136,7 +159,7 @@ export class NgbTimepicker implements ControlValueAccessor, | |||
| */ | |||
| @Input() size: 'small' | 'medium' | 'large'; | |||
|
|
|||
| constructor(config: NgbTimepickerConfig, private _ngbTimeAdapter: NgbTimeAdapter<any>) { | |||
| constructor(private readonly config: NgbTimepickerConfig, private _ngbTimeAdapter: NgbTimeAdapter<any>) { | |||
There was a problem hiding this comment.
As config becomes private, please rename to _config (see https://github.com/ng-bootstrap/ng-bootstrap/wiki/Contributions%3A-Code-conventions)
src/timepicker/timepicker.spec.ts
Outdated
| }); | ||
| })); | ||
|
|
||
| it('should increment / decrement minutes by 7', async(() => { |
There was a problem hiding this comment.
Could you please simplify tests, as we should use async/await or fakeAsync (I know you were inspired by already exsiting ones, but now there is a shorter way to write) →
Before:
it('should increment / decrement minutes by 7', async(() => {
//...
fixture.detectChanges();
fixture.whenStable()
.then(() => {
fixture.detectChanges();
return fixture.whenStable();
})
.then(() => {
// ...
});
}));After:
it('should increment / decrement minutes by 7', async(async () => {
// ...
fixture.detectChanges();
await fixture.whenStable();
fixture.detectChanges();
// ...
}));
src/timepicker/timepicker.ts
Outdated
| @@ -114,17 +118,36 @@ export class NgbTimepicker implements ControlValueAccessor, | |||
| /** | |||
| * Number of hours to increase or decrease when using a button. | |||
| */ | |||
| @Input() hourStep: number; | |||
| @Input() set hourStep(step: number) { | |||
| this._hourStep = isNumber(step) ? step : this.config.hourStep; | |||
|
Oh, also the build failed because of improper code formatting: https://travis-ci.org/ng-bootstrap/ng-bootstrap/builds/463821660#L508 You could run |
|
Thanks for the comments! I've updated the PR. |
Codecov Report
@@ Coverage Diff @@
## master #2903 +/- ##
==========================================
+ Coverage 91.16% 91.23% +0.06%
==========================================
Files 89 89
Lines 2863 2885 +22
Branches 466 475 +9
==========================================
+ Hits 2610 2632 +22
Misses 181 181
Partials 72 72
Continue to review full report at Codecov.
|
Closes #2851
Also added some tests for step setting via component input properties