Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(timepicker): set ViewEncapsulation.None forgotten in 4.0.0 #2932

Merged
merged 1 commit into from
Dec 17, 2018
Merged

fix(timepicker): set ViewEncapsulation.None forgotten in 4.0.0 #2932

merged 1 commit into from
Dec 17, 2018

Conversation

maxokorokov
Copy link
Member

Part of #2930

cc @fbasso

@maxokorokov maxokorokov added this to the 4.0.2 milestone Dec 17, 2018
@maxokorokov maxokorokov force-pushed the timepicker/fix/view-encapsulation branch from 8893764 to ff6dd01 Compare December 17, 2018 10:07
@fbasso
Copy link
Member

fbasso commented Dec 17, 2018

A class is required for the input styling inside the scss, otherwise the viewEncapsulation none will apply the rules to all input :

ng-bootstrap/src/timepicker/timepicker.scss

Line 50 in ff6dd01

input {

Another remark : a refactor would be nice to group some rules under the same base, for example:

.ngb-tp {
    ...
    &-input-container {
       ...
    }
}

@codecov-io

This comment has been minimized.

Sign in to view
@maxokorokov maxokorokov force-pushed the timepicker/fix/view-encapsulation branch from ff6dd01 to d184b00 Compare December 17, 2018 10:35
@maxokorokov
Copy link
Member Author

@fbasso thanks, amended!

@maxokorokov maxokorokov force-pushed the timepicker/fix/view-encapsulation branch from d184b00 to 3e06dd8 Compare December 17, 2018 10:54
@maxokorokov
Copy link
Member Author

maxokorokov commented Dec 17, 2018 •
edited

@fbasso I've added .ngb-tb-chevron, .ngb-tp-input and kept .chevron so it would work for any users who tried to override .chevron class.

The only way they could override .chevron is with adding !important, so all should be fine.

We should remove .chevron in 5.0.0

@fbasso
Copy link
Member

fbasso commented Dec 17, 2018

LGTM

@maxokorokov maxokorokov merged commit 1d01940 into ng-bootstrap:master Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbasso fbasso fbasso approved these changes

Assignees
No one assigned
Labels
component: timepicker needs: merging type: bug
Projects
None yet
Milestone
4.0.2
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@maxokorokov @fbasso @codecov-io