Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to switch from bootstrap with custom css to ng-bootstrap #2989

Open
Githamza opened this issue Jan 29, 2019 · 1 comment
Open

How to switch from bootstrap with custom css to ng-bootstrap #2989

Githamza opened this issue Jan 29, 2019 · 1 comment

Comments

@Githamza
Copy link

Githamza commented Jan 29, 2019

In my company we have already custom boostrap CSS .

Now we are working with Angular so I would switch to ng-bootstrap.

The problem is that we would use our graphic identity with ng-bootstrap.

Should we reedit ng-bootstrap CSS or there is a solution to switch our scss files to new ng-bootstrap ?

Thanks.

Angular: 6

ng-bootstrap: 4

Bootstrap: 4

@maxokorokov
Copy link
Member

Hey, @Githamza!

We have two types of components:

  1. bootstrap components → ex. alert, tabset, pagiation, etc. They exist in bootstrap and we completely reuse HTML markup and CSS classes provided by bootstrap. These should work fine with your custom theme, as we don't invent anything on top of standard Bootstrap.

  2. non-bootstrap components → ex. datepicker, rating, timepicker. They do not exist in bootstrap, we have some custom styles for them, but we also try using standard bootstrap CSS classes in their markup. All out components have encapsulation: ViewEncapsulation.None, so you should be able override these styles quite easily. Ex. for datepicker you have custom .ngb-dp-xxx classes that you could tweak.

Now, there is also a PR #2947 in works for releasing CSS/SASS files for the second group of components as a part of the library (with variables based on the bootstrap variables, etc). But I can't make any commitments on dates for this at the moment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants