Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add missing exports #2997

Merged
merged 1 commit into from
Feb 4, 2019
Merged

Conversation

marclaval
Copy link
Contributor

When building ng-bootstrap with Ivy, I'm getting the following error:

BUILD ERROR
src/buttons/label.ts(8,14): error TS-993001: Unsupported private class NgbButtonLabel. This class is visible to consumers via NgbButtonsModule -> NgbButtonLabel, but is not exported from the top-level library entrypoint.
src/buttons/radio.ts(80,14): error TS-993001: Unsupported private class NgbRadio. This class is visible to consumers via NgbButtonsModule -> NgbRadio, but is not exported from the top-level library entrypoint.
src/dropdown/dropdown.ts(71,14): error TS-993001: Unsupported private class NgbDropdownAnchor. This class is visible to consumers via NgbDropdownModule -> NgbDropdownAnchor, but is not exported from the top-level library entrypoint.
src/dropdown/dropdown.ts(95,14): error TS-993001: Unsupported private class NgbDropdownToggle. This class is visible to consumers via NgbDropdownModule -> NgbDropdownToggle, but is not exported from the top-level library entrypoint.
src/dropdown/dropdown.ts(28,14): error TS-993001: Unsupported private class NgbDropdownMenu. This class is visible to consumers via NgbDropdownModule -> NgbDropdownMenu, but is not exported from the top-level library entrypoint.

I don't know why it happens ... Adding the missing exports solves the issue.

@marclaval marclaval changed the title refactor: add missing exports fix: add missing exports Feb 4, 2019
@codecov-io
Copy link

codecov-io commented Feb 4, 2019

Codecov Report

Merging #2997 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #2997   +/-   ##
=======================================
  Coverage   92.26%   92.26%           
=======================================
  Files          91       91           
  Lines        2870     2870           
  Branches      463      463           
=======================================
  Hits         2648     2648           
  Misses        163      163           
  Partials       59       59
Flag Coverage Δ
#e2e 60.1% <ø> (ø) ⬆️
#unit 90.64% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/index.ts 100% <ø> (ø) ⬆️
src/dropdown/dropdown.module.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 43186af...badfc27. Read the comment docs.

Copy link
Member

@maxokorokov maxokorokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@maxokorokov maxokorokov merged commit 932d7f6 into ng-bootstrap:master Feb 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants