fix(autoclose): fix popup automatic closing on touch on iOS #3004
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3004 +/- ##
==========================================
- Coverage 92.26% 92.13% -0.14%
==========================================
Files 91 91
Lines 2870 2873 +3
Branches 463 468 +5
==========================================
- Hits 2648 2647 -1
Misses 163 163
- Partials 59 63 +4
Continue to review full report at Codecov.
|
maxokorokov
commented
Feb 7, 2019
| const closeableClicks$ = fromEvent<MouseEvent>(this._document, iOS ? 'touchend' : 'mouseup') | ||
| .pipe( | ||
| withLatestFrom(mouseDowns$), filter(([_, shouldClose]) => shouldClose), | ||
| delay(iOS ? 16 : 0), takeUntil(closed$)); |
There was a problem hiding this comment.
If anybody has a better solution for this, please share it :)
Problem is when there is a click handler on a triggering element (say, button):
- to open:
click→open() - to close:
touchdown→touchup→click (is still generated that leads to)→open() (popup reopening)
by delaying the touchup, click and open() are processed while the popup is still opened
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on Android, Windows 10 with touch and iOS.
Autoclose was broken only on iOS, other browsers work fine with
mousedown/mouseupwhileiOSneeds to havetouchstart/touchendFixes #2995
cc @divdavem