fix(dropdown): wrong positioning calculation #3058
Merged
+28
−29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3058 +/- ##
==========================================
- Coverage 92.27% 90.83% -1.45%
==========================================
Files 91 90 -1
Lines 3015 2999 -16
Branches 485 484 -1
==========================================
- Hits 2782 2724 -58
- Misses 171 207 +36
- Partials 62 68 +6
Continue to review full report at Codecov.
|
fbasso
force-pushed
the
positioning-dropdown
branch
3 times, most recently
from
e368fb9
to
de3fda9
Compare
fbasso
force-pushed
the
positioning-dropdown
branch
2 times, most recently
from
c9afe6f
to
273aa85
Compare
maxokorokov
requested changes
Mar 26, 2019
src/dropdown/dropdown.spec.ts
Outdated
| const dropdownElement = document.querySelector('div[ngbDropdownMenu]'); | ||
| const parentContainer = dropdownElement.parentNode; | ||
| expect(parentContainer).toHaveCssClass('dropdown'); | ||
| expect(parentContainer.parentNode).toBe(document.body, 'The dropdown should be attached to the body'); | ||
|
|
||
| }); | ||
|
|
||
| it('should toggle at the second placement if needed', () => { |
There was a problem hiding this comment.
should second placement if the first one doesn't fit ?
src/dropdown/dropdown.spec.ts
Outdated
| fixture.detectChanges(); | ||
| const dropdownEl = compiled.querySelector('[ngbdropdownmenu]'); | ||
| const targetElement = compiled.querySelector('button'); | ||
| // expect(dropdownElement.getAttribute('x-placement')).toBe('right'); |
fbasso
force-pushed
the
positioning-dropdown
branch
from
273aa85
to
b5f8a07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #3056
The fix only adds the 'show' class before the positioning, but I don't know if it's the best solution as the class attribute is bound. I tried to 'unbind' the class, but it's much more painfull.