Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(aria): set radio buttons role as "radiogroup" #3085

Merged
merged 1 commit into from
Mar 25, 2019

Conversation

henetiriki
Copy link
Contributor

closes #3084

Before submitting a pull request, please make sure you have at least performed the following:

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated any applicable tests.

@codecov-io
Copy link

Codecov Report

Merging #3085 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3085   +/-   ##
=======================================
  Coverage   92.27%   92.27%           
=======================================
  Files          91       91           
  Lines        3015     3015           
  Branches      485      485           
=======================================
  Hits         2782     2782           
  Misses        171      171           
  Partials       62       62
Flag Coverage Δ
#e2e 60.69% <ø> (ø) ⬆️
#unit 90.76% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/buttons/radio.ts 95.08% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f54bc8d...1f10b5d. Read the comment docs.

Copy link
Member

@maxokorokov maxokorokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

Indeed looks like it should be radiogroup

@maxokorokov maxokorokov merged commit 21df9a6 into ng-bootstrap:master Mar 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Radio buttons "role" incorrectly set at "group" - should be "radiogroup"
3 participants