feat(datepicker): expose validators minDate, maxDate, invalidDate #3126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @maxokorokov. Is there any chance for getting this reviewed? If you have any remarks, l would be happy to apply them. |
maxokorokov
force-pushed
the
datepicker/feature/expose-validators
branch
from
5d7ba8c
to
b56b8e7
Compare
maxokorokov
approved these changes
May 29, 2019
There was a problem hiding this comment.
Thanks @03byron!
I've just rebased on master because of conflicts and added comment for the NgbDateValidators:
Cheers,
Max
Codecov Report
@@ Coverage Diff @@
## master #3126 +/- ##
==========================================
+ Coverage 92.04% 92.07% +0.02%
==========================================
Files 91 92 +1
Lines 3054 3090 +36
Branches 505 513 +8
==========================================
+ Hits 2811 2845 +34
Misses 179 179
- Partials 64 66 +2
Continue to review full report at Codecov.
|
maxokorokov
added a commit
to maxokorokov/ng-bootstrap
that referenced
this pull request
Jun 3, 2019
…Date (ng-bootstrap#3126)" This reverts commit 509bba3.
mijohnsmith
pushed a commit
to mijohnsmith/ng-bootstrap
that referenced
this pull request
Jun 27, 2019
…Date (ng-bootstrap#3126)" (ng-bootstrap#3219) This reverts commit 509bba3.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up for #3115.