fix(datepicker): access view child from ngAfterViewInit #3152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
datepicker accessed a view child from the ngAfterContentInit hook instead of accessing it from the ngAfterViewInit hook. This doesn't work anymore with Ivy. That is a regression in Ivy, but is also an issue with ng-bootstrap which doesn't respect the standard life-cycle. Besides, the component didn't implement the AfterContentInit interface. It now implements the AfterViewInit interface. fix ng-bootstrap#3150
Codecov Report
@@ Coverage Diff @@
## master #3152 +/- ##
=======================================
Coverage 92.33% 92.33%
=======================================
Files 91 91
Lines 3001 3001
Branches 483 483
=======================================
Hits 2771 2771
Misses 166 166
Partials 64 64
Continue to review full report at Codecov.
|
|
I've stumbled upon the same issue when making the unit tests of ng-bootstrap to pass with Ivy. This fix LGTM. |
benouat
approved these changes
Apr 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
datepicker accessed a view child from the ngAfterContentInit hook instead of accessing it from the ngAfterViewInit hook.
This doesn't work anymore with Ivy. That is a regression in Ivy, but is also an issue with ng-bootstrap which doesn't respect the standard life-cycle.
Besides, the component didn't implement the AfterContentInit interface.
It now implements the AfterViewInit interface.
fix #3150
Before submitting a pull request, please make sure you have at least performed the following: