Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): z-index set when appended to body #3157

Merged
merged 1 commit into from
Apr 30, 2019

Conversation

fbasso
Copy link
Member

@fbasso fbasso commented Apr 30, 2019

fix #3061

@codecov-io
Copy link

Codecov Report

Merging #3157 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3157      +/-   ##
==========================================
+ Coverage   92.34%   92.34%   +<.01%     
==========================================
  Files          91       91              
  Lines        3003     3004       +1     
  Branches      483      483              
==========================================
+ Hits         2773     2774       +1     
  Misses        166      166              
  Partials       64       64
Flag Coverage Δ
#e2e 61.81% <100%> (+0.01%) ⬆️
#unit 89.96% <100%> (ø) ⬆️
Impacted Files Coverage Δ
src/dropdown/dropdown.ts 94.19% <100%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e54eef...fe29b56. Read the comment docs.

Copy link
Member

@maxokorokov maxokorokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to me as a fix

But we should probably:

  • add e2e tests to open dropdown, tooltip, typeahead, etc. in a modal when attached to body
  • put this in scss later as not possible now

@maxokorokov maxokorokov merged commit ec73fc2 into ng-bootstrap:master Apr 30, 2019
@fbasso fbasso deleted the dropdown-zindex branch April 30, 2019 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Z-index issue on ngb-dropdown with container="body"
3 participants