fix(datepicker): don't change month content if navigation is prevented #3173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous attempt in navigation cancellation changed was buggy. After cancellation year and month select boxes stayed unchanged, but the actual month content changed. Test expectations were incomplete.
maxokorokov
commented
May 6, 2019
|
|
||
| const button = fixture.nativeElement.querySelector('button#btn'); | ||
| button.click(); | ||
| fixture.detectChanges(); | ||
|
|
||
| expect(getMonthSelect(fixture.nativeElement).value).toBe('8'); | ||
| expect(getYearSelect(fixture.nativeElement).value).toBe('2016'); | ||
| expect(getDay(fixture.nativeElement, 0).innerText).toBe('1'); |
There was a problem hiding this comment.
This was failing with previous version, as the month was actually changed
Codecov Report
@@ Coverage Diff @@
## master #3173 +/- ##
==========================================
- Coverage 92.34% 92.34% -0.01%
==========================================
Files 91 91
Lines 3005 3004 -1
Branches 484 484
==========================================
- Hits 2775 2774 -1
Misses 166 166
Partials 64 64
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous attempt in navigation cancellation changed was buggy → #3044
After cancellation year and month select boxes stayed unchanged, but the actual month content changed.
Test expectations were incomplete.