Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(alert): project content before the closing button #3176

Merged
merged 1 commit into from
May 7, 2019
Merged

fix(alert): project content before the closing button #3176

merged 1 commit into from
May 7, 2019

Conversation

maxokorokov
Copy link
Member

Fixes #3171

@benouat could you PTAL / merge if ok ?

@maxokorokov maxokorokov added this to the 4.1.3 milestone May 6, 2019
benouat
benouat approved these changes May 7, 2019
View reviewed changes
Copy link
Member

@benouat benouat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, will proceed with merge! 👍

@benouat benouat merged commit 3e1dba9 into ng-bootstrap:master May 7, 2019
@maxokorokov
Copy link
Member Author

@benouat, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benouat benouat benouat approved these changes

Assignees

@benouat benouat

Labels
component: alert needs: review
Projects
None yet
Milestone
4.1.3
Development

Successfully merging this pull request may close these issues.

Change the order of the alert component template content to correct screen readers output
2 participants
@maxokorokov @benouat