Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal): Add xl size for modal #2943 #3239

Merged
merged 1 commit into from
Jun 24, 2019

Conversation

IAfanasov
Copy link
Contributor

Before submitting a pull request, please make sure you have at least performed the following:

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • [] added/updated any applicable tests.
  • added/updated any applicable API documentation.
  • added/updated any applicable demos.

@codecov-io
Copy link

Codecov Report

Merging #3239 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3239   +/-   ##
=======================================
  Coverage   92.04%   92.04%           
=======================================
  Files          91       91           
  Lines        3054     3054           
  Branches      505      505           
=======================================
  Hits         2811     2811           
  Misses        179      179           
  Partials       64       64
Flag Coverage Δ
#e2e 62.99% <ø> (ø) ⬆️
#unit 89.47% <ø> (ø) ⬆️
Impacted Files Coverage Δ
src/modal/modal-config.ts 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7a17683...08e6b9f. Read the comment docs.

@benouat benouat added this to the 5.0.0-rc.0 milestone Jun 24, 2019
@benouat benouat merged commit 998f358 into ng-bootstrap:master Jun 24, 2019
mijohnsmith pushed a commit to mijohnsmith/ng-bootstrap that referenced this pull request Jun 27, 2019
@IAfanasov IAfanasov deleted the feature/modalXl branch June 29, 2019 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants