Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(demo): missing Object.values() polyfill for IE. #3249

Merged
merged 1 commit into from
Jun 24, 2019

Conversation

benouat
Copy link
Member

@benouat benouat commented Jun 24, 2019

Object.values is used at runtime to compute all the table of content navigation.

Polyfill has been accidentally removed recently, crashing demo website on all IE browsers

We need to add this polyfill for IE compatibility in the demo website.
@codecov-io
Copy link

Codecov Report

Merging #3249 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3249   +/-   ##
=======================================
  Coverage   90.14%   90.14%           
=======================================
  Files          91       91           
  Lines        2700     2700           
  Branches      503      503           
=======================================
  Hits         2434     2434           
  Misses        207      207           
  Partials       59       59
Flag Coverage Δ
#e2e 55.03% <ø> (ø) ⬆️
#unit 87.28% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a20df01...7f60543. Read the comment docs.

@benouat benouat added this to the 5.0.0-rc.0 milestone Jun 24, 2019
@benouat benouat merged commit 0eff381 into ng-bootstrap:master Jun 24, 2019
mijohnsmith pushed a commit to mijohnsmith/ng-bootstrap that referenced this pull request Jun 27, 2019
)

We need to add this polyfill for IE runtime compatibility in the demo website.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants