fix(toast): proper handling of autohide toggling
#3283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benouat
force-pushed
the
fix/toast/autohide-toggling
branch
from
c0598e1
to
fa66314
Compare
Codecov Report
@@ Coverage Diff @@
## master #3283 +/- ##
==========================================
+ Coverage 90.78% 90.78% +<.01%
==========================================
Files 95 95
Lines 2713 2714 +1
Branches 508 508
==========================================
+ Hits 2463 2464 +1
Misses 190 190
Partials 60 60
Continue to review full report at Codecov.
|
benouat
force-pushed
the
fix/toast/autohide-toggling
branch
from
fa66314
to
07c32ba
Compare
Toasts initially setup with `[autohide]="true"`were wrongly still emitting `(hide)` output after toggling `autohide` to `false`. A new demo has also been created to illustrate the `autohide` toggling support, 'Prevent autohide on mouseover'. Fixes ng-bootstrap#3280
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Toasts initially setup with
[autohide]="true"were wrongly still emitting(hide)output after togglingautohidetofalse.A new demo has also been created to illustrate the
autohidetoggling support, 'Prevent autohide on mouseover'.Fixes #3280