Bug: Datetime picker defaults to 12 PM instead of 12 AM

[shyamal890]

Bug description:

When one selects a date through ngb-datepicker it automatically takes the time as 12PM when it should take 12 AM by default.

As seen in the demo below. Given I am in IST timezone (GMT+5:30) when I select say for example 15th Aug, 2019. I get the following output: 2019-08-15T06:30:00.000Z which is 15th Aug, 2019, 12 PM instead of expected 2019-08-14T18:30:00.000Z which is 15th Aug, 2019, 12 AM.

You can also check in Material it selects 12 AM: https://stackblitz.com/edit/material-datepicker-12am

Link to minimally-working StackBlitz that reproduces the issue:

https://stackblitz.com/edit/ngb-datepicker-12pm-issue

Versions of Angular, ng-bootstrap and Bootstrap:

Angular: 82.3

ng-bootstrap: 5.0.0

Bootstrap: 4+

[shyamal890]

@maxokorokov @pkozlowski-opensource Most of the UI tools out there have 12 AM as the default. Any idea on when the behavior would reverted back from 12 PM to 12 AM?

[shyamal890]

Would appreciate a reply on this

[shyamal890]

Kindly share an update on this bug.

[shyamal890]

Dear team, would appreciate an update on this bug.

[gpolychronis]

Hello @shyamal890 .
You can override the NgbDateNativeAdapter Injectable to provide your own implementation i.e:

`
@Injectable()
export class CustomAdapter extends NgbDateNativeAdapter {

protected _toNativeDate(date: NgbDateStruct): Date {
const jsDate = new Date(date.year, date.month - 1, date.day, 0);
// avoid 30 -> 1930 conversion
jsDate.setFullYear(date.year);
return jsDate;
}
}
`

Ensure to include it in your providers i.e:

providers: [ {provide: NgbDateAdapter, useClass: CustomAdapter} ]

See also example: https://ng-bootstrap.github.io/#/components/datepicker/examples#adapter

[shyamal890]

@gpolychronis I will try this out and get back here.

[AGLearning]

When you use NgbDateNativeUTCAdapter instead of NgbDateNativeAdapter hour is correct (12AM UTC)

[linch90]

Dear ng-bootstrap team, provide a custom implementation for this adapter is a solution, but why not take 12AM as the default for the NgbDateNativeAdapter, while the NgbDateNativeUTCAdapter is 12AM default, what's the purpose for this 12PM implementation? It's really odd.