fix: support 'strictTemplates' flag for public API #3623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following use-cases for the public APIs: 1. Boolean `@Input`s like `disabled` where value is not required: ```html <input ngbButton disabled></input> ``` by adding ```ts static ngAcceptInputType_disabled: boolean | ''; ``` 2. All union types like `'vertical' | 'horizontal'`: ``` // template <nav ngbNav [orientation]="orientation"></nav> // component orientation = 'vertical'; ``` by adding: ```ts static ngAcceptInputType_orientation: string; ``` 3. Cases where the directive selector matches the input with the optional value ```html <button [ngbPanelToggle]="p"></button> <button ngbPanelToggle></button> ``` by adding: ```ts static ngAcceptInputType_ngbPanelToggle: NgbPanel | ''; ``` Also makes all internal library templates to work with `strictTemplates`. Fixes ng-bootstrap#3619
Codecov Report
@@ Coverage Diff @@
## master #3623 +/- ##
=======================================
Coverage 91.71% 91.71%
=======================================
Files 100 100
Lines 2909 2909
Branches 537 537
=======================================
Hits 2668 2668
Misses 183 183
Partials 58 58
Continue to review full report at Codecov.
|
benouat
approved these changes
Feb 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following use-cases for the public APIs:
@Inputs likedisabledwhere value is not required:by adding
'vertical' | 'horizontal':by adding:
by adding:
Also makes all internal library templates to work with
strictTemplates.Fixes #3619
cc @pkozlowski-opensource