Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(dropdown): close dropdown when focus leaves menu #3625

Merged
merged 2 commits into from
Jun 11, 2020

Conversation

Smoggy
Copy link
Contributor

@Smoggy Smoggy commented Feb 26, 2020

fix of the issue #3140

Before submitting a pull request, please make sure you have at least performed the following:

  • read and followed the CONTRIBUTING.md guide.
  • built and tested the changes locally.
  • added/updated any applicable tests.
  • added/updated any applicable API documentation.
  • added/updated any applicable demos.

Removed a forgotten `console.log` and also turn `_onFocusOut` method into an actual private method
@codecov-commenter
Copy link

Codecov Report

Merging #3625 into master will decrease coverage by 0.30%.
The diff coverage is 70.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3625      +/-   ##
==========================================
- Coverage   91.53%   91.23%   -0.31%     
==========================================
  Files         100      100              
  Lines        2930     2988      +58     
  Branches      539      555      +16     
==========================================
+ Hits         2682     2726      +44     
- Misses        186      192       +6     
- Partials       62       70       +8     
Flag Coverage Δ
#e2e 56.22% <70.58%> (-0.67%) ⬇️
#unit 87.75% <0.00%> (-0.65%) ⬇️
Impacted Files Coverage Δ
src/dropdown/dropdown.ts 91.71% <70.58%> (-2.41%) ⬇️
src/nav/nav.ts 90.10% <0.00%> (-9.90%) ⬇️
src/util/positioning.ts 95.86% <0.00%> (-0.04%) ⬇️
src/nav/nav-config.ts 100.00% <0.00%> (ø)
src/modal/modal-config.ts 100.00% <0.00%> (ø)
src/modal/modal-window.ts 93.61% <0.00%> (+0.13%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a92bab4...c90940e. Read the comment docs.

@benouat benouat merged commit dc7990f into ng-bootstrap:master Jun 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants