Add schematics to @ng-bootstrap/ng-bootstrap
#3669
Merged
+1,224
−548
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxokorokov
changed the title
@ng-bootstrap/ng-bootstrap
devoto13
reviewed
Apr 7, 2020
schematics/ng-add/setup-project.ts
Outdated
| import {getAppModulePath} from '@schematics/angular/utility/ng-ast-utils'; | ||
| import {getProject} from '@schematics/angular/utility/project'; | ||
| import * as path from 'path'; | ||
| import * as ts from 'typescript'; |
There was a problem hiding this comment.
Recently fixed issue in another library, which was caused by the similar code. @schematics/angular bundles its own version of TS and as a result AST is created by the workspace version of TS (ts.createSourceFile() call), while it is modified by the version bundled by @schematics/angular. If these versions are different it crashes. The reproduction was to ng new my-proj with latest CLI, change workspace TS to 3.7.5 and ng add <lib>.
See FortAwesome/angular-fontawesome#238 for more details.
There was a problem hiding this comment.
Thank you, will check this
Codecov Report
@@ Coverage Diff @@
## master #3669 +/- ##
==========================================
- Coverage 91.53% 91.53% -0.01%
==========================================
Files 100 100
Lines 2930 2928 -2
Branches 539 539
==========================================
- Hits 2682 2680 -2
Misses 186 186
Partials 62 62
Continue to review full report at Codecov.
|
This was referenced Apr 15, 2020
|
Pushed the following changes:
Full list of what is supported at the moment:
What is still missing:
@benouat, could you please take a look at this? |
benouat
reviewed
Apr 16, 2020
Based on the '@ng-bootstrap/schematics' latest version
maxokorokov
added a commit
that referenced
this pull request
Apr 17, 2020
- `ng add @ng-bootstrap/ng-bootstrap` with optional `--project` - installing `bootstrap`, `@ng-bootstrap/ng-bootstrap` and `@angular/localize` dependencies - adding `@angular/localize` polyfill - adding `NgbModule` to the main application module - adding styles for `.scss` and `.sass` in the style file directly - warning for unsupported project styles for `less`, `stylus` - adding `bootstrap.min.css` to `angular.json` in case of CSS styles / unsupported project styles
maxokorokov
added a commit
that referenced
this pull request
Apr 20, 2020
- `ng add @ng-bootstrap/ng-bootstrap` with optional `--project` - installing `bootstrap`, `@ng-bootstrap/ng-bootstrap` and `@angular/localize` dependencies - adding `@angular/localize` polyfill - adding `NgbModule` to the main application module - adding styles for `.scss` and `.sass` in the style file directly - warning for unsupported project styles for `less`, `stylus` - adding `bootstrap.min.css` to `angular.json` in case of CSS styles / unsupported project styles fix(schematics): linting
Merged
maxokorokov
added a commit
that referenced
this pull request
Apr 20, 2020
- `ng add @ng-bootstrap/ng-bootstrap` with optional `--project` - installing `bootstrap`, `@ng-bootstrap/ng-bootstrap` and `@angular/localize` dependencies - adding `@angular/localize` polyfill - adding `NgbModule` to the main application module - adding styles for `.scss` and `.sass` in the style file directly - warning for unsupported project styles for `less`, `stylus` - adding `bootstrap.min.css` to `angular.json` in case of CSS styles / unsupported project styles fix(schematics): linting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the latest version of the
@ng-bootstrap/schematics(it will be deprecated)Mostly technical PR, no new features/fixes:
@ng-bootstrap/schematics@ng-bootstrap/ng-bootstrappackage with built schematicsFixes #2361
@benouat