Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alert): add .fade class only with animations on #3756

Conversation

maxokorokov
Copy link
Member

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #3756 into animations will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           animations    #3756   +/-   ##
===========================================
  Coverage       91.64%   91.64%           
===========================================
  Files             107      107           
  Lines            3077     3077           
  Branches          564      564           
===========================================
  Hits             2820     2820           
  Misses            189      189           
  Partials           68       68           
Flag Coverage Δ
#e2e 54.69% <ø> (ø)
#unit 88.69% <ø> (ø)
Impacted Files Coverage Δ
src/alert/alert.ts 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f9fd6ac...be21249. Read the comment docs.

Copy link
Member

@benouat benouat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fbasso
Copy link
Member

fbasso commented Jun 10, 2020

Fine for me too 😉

@maxokorokov maxokorokov merged commit 5e941d7 into ng-bootstrap:animations Jun 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants