-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(carousel): accessibility #3773
Conversation
Codecov Report
@@ Coverage Diff @@
## master #3773 +/- ##
==========================================
- Coverage 91.23% 91.18% -0.06%
==========================================
Files 100 100
Lines 2988 3016 +28
Branches 555 562 +7
==========================================
+ Hits 2726 2750 +24
Misses 192 192
- Partials 70 74 +4
Continue to review full report at Codecov.
|
753cf47
to
d64e913
Compare
d64e913
to
bf914b3
Compare
I still have one consideration regarding all these changes. I was having a look a the first demo, if you click on previous/next arrow, I assume that focus will be somewhere caught inside the widget, but there is no visual hint such as an outline. Hence the carousel gets stuck in pause mode, and for the end user you don't know why... It's not very intuitive that you have to click elsewhere for the carousel to resume. |
506228b
to
40c10e3
Compare
0da4219
to
9dc12de
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I just left a couple nitpick comments.
9dc12de
to
feea237
Compare
@benouat Thank you for your review and your comments. I have updated the code accordingly. |
This PR adds accessibility to the carousel:
pauseOnFocus
property)In the future, it would be nice to integrate assistive-webdriver to execute end-to-end tests with a screen reader.
Before submitting a pull request, please make sure you have at least performed the following:
Fixes #3755