Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(animations): pass transition context with animation disabled #3781

Merged
merged 1 commit into from
Jun 22, 2020
Merged

fix(animations): pass transition context with animation disabled #3781

merged 1 commit into from
Jun 22, 2020

Conversation

maxokorokov
Copy link
Member

Fixes an issue when the context was not passed across two transitions when animation = false (see test for the example)

@maxokorokov maxokorokov added this to the 7.0.0 milestone Jun 22, 2020
@maxokorokov maxokorokov requested a review from fbasso June 22, 2020 08:44
@maxokorokov maxokorokov mentioned this pull request Jun 22, 2020
Merged
fbasso
fbasso approved these changes Jun 22, 2020
View reviewed changes
Copy link
Member

@fbasso fbasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM !

@maxokorokov
Copy link
Member Author

@fbasso thanks, merging!

@maxokorokov maxokorokov merged commit 0e2120e into ng-bootstrap:animations Jun 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fbasso fbasso fbasso approved these changes

Assignees
No one assigned
Labels
needs: review type: animation type: bug
Projects
None yet
Milestone
8.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maxokorokov @fbasso