Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(modal): add modalDialogClass to modal-dialog div #3826

Merged
merged 3 commits into from
Mar 23, 2021

Conversation

MisuleT
Copy link
Contributor

@MisuleT MisuleT commented Aug 5, 2020

Before submitting a pull request, please make sure you have at least performed the following:

  • read and followed the CONTRIBUTING.md and DEVELOPER.md guide.
  • built and tested the changes locally.
  • added/updated any applicable tests.
  • added/updated any applicable API documentation.
  • added/updated any applicable demos.

@jnizet
Copy link
Member

jnizet commented Aug 5, 2020

Hi @MisuleT

Thanks for the PR, but could you please explain why you think we should add such a configuration option? Can't you use the already supported windowClass option?

For example with such a selector in your stylesheet:

.myCustomWindowClass .modal-dialog {
  ...
}

@MisuleT
Copy link
Contributor Author

MisuleT commented Aug 6, 2020

Hi @jnizet

We depend on another library in our project, that is based on Bootstrap. We already use windowClass, but we have to add another class to modal-dialog div for the correct library function.

We created workaround where we add class 'g-modal' to size option. But it is not clear solution and if you change this option it won't work for us.

options.size += ' g-modal';

@MisuleT
Copy link
Contributor Author

MisuleT commented Jan 19, 2021

Hi @jnizet

I fixed the test and this pull request is ready to merge :)

@maxokorokov maxokorokov added this to the 9.1.0 milestone Mar 23, 2021
@maxokorokov maxokorokov merged commit 37c0331 into ng-bootstrap:master Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants