Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(progressbar): simplify template #3841

Merged

Conversation

VolodymyrBaydalka
Copy link
Contributor

Reduced number of elements by moving "progress" class to host element. As result height can be changed via style.

@benouat
Copy link
Member

benouat commented Aug 25, 2020

Hey, the build is failing, you have unformatted files
Please run yarn check-format locally and have a look at what's reported there.

@maxokorokov maxokorokov modified the milestones: 7.0.0, 8.0.0 Oct 8, 2020
Copy link
Member

@maxokorokov maxokorokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@maxokorokov maxokorokov merged commit 89ec4fe into ng-bootstrap:master Nov 3, 2020
@mradcliffe
Copy link

A couple of workarounds in case anyone else had extended NgbProgressBar and relied on a wrapper class with bootstrap's progress class to make fancy progress bars.

  • Use increase specificity in CSS e.g. my-custom-progressbar.progress { }
  • Set the new height property to 'auto', use HostBinding on other styles added by .progress on the component selector, use a wrapper class to reset the height to the default value because the height property applies to all elements that use .progress.
  • Don't extend NgbProgressBar, re-write everything from scratch using bootstrap classes directly.

@VolodymyrBaydalka VolodymyrBaydalka deleted the simplify-progressbar branch September 15, 2021 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants