New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(popover,tooltip): run transaction inside angular zone #3909

Merged

maxokorokov merged 1 commit into ng-bootstrap:master from VolodymyrBaydalka:bug/3896_transaction_outside_ngzone

Jan 5, 2021

Contributor

VolodymyrBaydalka commented Nov 23, 2020

Forcing to run ngbRunTransition inside angular zone, because NgZone.onStable is called outside angular zone.

closes #3896


          fix(popover,tooltip): run transaction inside angular zone

ffc5003

maxokorokov added component: popover component: tooltip needs: review labels

maxokorokov added this to the 8.0.1 milestone

maxokorokov approved these changes

View reviewed changes

Member

maxokorokov left a comment

LGTM, thanks!
I was trying to come up with tests for this for some time, but couldn't.
If you have any ideas - will be helpful.

maxokorokov merged commit a2d3a44 into ng-bootstrap:master

maxokorokov mentioned this pull request

NgbNav wont work with dynamic tabs loaded from Http-Request #3920

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment