fix(animations): delegate 'animation' flag to 'NgbConfig' #3939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxokorokov
force-pushed
the
animations/fix/config-injection-order
branch
from
6b16f1f
to
09c06e3
Compare
Component configs now delegate 'animation' flag to 'NgbConfig' if it is not set explicitly. Fixes ng-bootstrap#3893
maxokorokov
force-pushed
the
animations/fix/config-injection-order
branch
from
09c06e3
to
61d8a76
Compare
fbasso
approved these changes
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Component configs now delegate the
animationflag toNgbConfigif it is not set explicitly.Fixes #3893