fix(animations): don't reflow in 'ngbRunTransition' #3962
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxokorokov
commented
Jan 20, 2021
| @@ -397,7 +395,7 @@ export class NgbAccordion implements AfterContentChecked { | |||
| this.activeIds = this.panels.filter(panel => panel.isOpen && !panel.disabled).map(panel => panel.id); | |||
| } | |||
|
|
|||
| private _runTransitions(animation: boolean, emitEvent = true) { | |||
| private _runTransitions(animation: boolean) { | |||
There was a problem hiding this comment.
note: removing this, because it is never used
maxokorokov
force-pushed
the
animations/fix/unnecessary-reflows
branch
from
f1b1637
to
b0a9cca
Compare
fbasso
reviewed
Jan 20, 2021
Replace a generic `reflow()` call in `ngbRunTransition`: - introduce granular per-component reflows only when necessary - take into account `animation` flag for reflows Fixes ng-bootstrap#3954 Fixes ng-bootstrap#3952
maxokorokov
force-pushed
the
animations/fix/unnecessary-reflows
branch
from
b0a9cca
to
a96cb42
Compare
fbasso
approved these changes
Jan 20, 2021
There was a problem hiding this comment.
Thanks for the PR @maxokorokov, LGTM !
Besides fixing the issues, I feel the code much better this way, with a more fine grain control on what to do for each animation, with or without animation enabled.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace a generic
reflow()call inngbRunTransition:animationflag for reflowsFixes #3954
Fixes #3952