Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: renamed .sr-only to .visually-hidden #3982

Merged
merged 1 commit into from
Jan 28, 2021
Merged

fix: renamed .sr-only to .visually-hidden #3982

merged 1 commit into from
Jan 28, 2021

Conversation

ExFlo
Copy link
Collaborator

@ExFlo ExFlo commented Jan 28, 2021

Before submitting a pull request, please make sure you have at least performed the following:

  • read and followed the CONTRIBUTING.md and DEVELOPER.md guide.
  • built and tested the changes locally.
  • added/updated any applicable tests.
  • added/updated any applicable API documentation.
  • added/updated any applicable demos.

@ExFlo ExFlo mentioned this pull request Jan 28, 2021
Closed
49 tasks
@maxokorokov maxokorokov added this to the 10.0.0 milestone Jan 28, 2021
maxokorokov
maxokorokov approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@maxokorokov maxokorokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maxokorokov maxokorokov merged commit 23afd37 into ng-bootstrap:bootstrap5 Jan 28, 2021
fbasso pushed a commit that referenced this pull request Mar 10, 2021
@ExFlo @fbasso
fix: renamed .sr-only to .visually-hidden (#3982)
c01bb63
fbasso pushed a commit to fbasso/ng-bootstrap that referenced this pull request Mar 12, 2021
@ExFlo @fbasso
fix: renamed .sr-only to .visually-hidden (ng-bootstrap#3982)
e85d248
fbasso pushed a commit that referenced this pull request Mar 25, 2021
@ExFlo @fbasso
fix: renamed .sr-only to .visually-hidden (#3982)
e919f19
fbasso pushed a commit to fbasso/ng-bootstrap that referenced this pull request May 12, 2021
@ExFlo @fbasso
fix: renamed .sr-only to .visually-hidden (ng-bootstrap#3982)
09eb6b2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxokorokov maxokorokov maxokorokov approved these changes

Assignees
No one assigned
Labels
bootstrap 5 needs: merging
Projects
None yet
Milestone
12.0.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ExFlo @maxokorokov