feat(datepicker): allow overriding month label correctly #4023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxokorokov
force-pushed
the
datepicker/fix/month-format
branch
2 times, most recently
from
77b1115
to
23ca41c
Compare
- introduces a new `getMonthLabel(date: NgbDateStruct): string` method to datepicker i18n - makes default i18n datepicker implementation accessible publicly Fixes ng-bootstrap#3863
maxokorokov
force-pushed
the
datepicker/fix/month-format
branch
from
23ca41c
to
54a836a
Compare
Codecov Report
@@ Coverage Diff @@
## master #4023 +/- ##
=======================================
Coverage 88.31% 88.31%
=======================================
Files 111 111
Lines 3525 3526 +1
Branches 646 646
=======================================
+ Hits 3113 3114 +1
Misses 346 346
Partials 66 66
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getMonthLabel(date: NgbDateStruct): stringmethod to datepicker i18nFixes #3863