feat(rating): set cursor on stars of rating component #411
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I saw this too, I haven't thought about the solution but I don't dislike that one. |
|
Sorry for the failing build. I will fix the formatting and amend the commit. |
jnizet
force-pushed
the
feat/cursor-on-rating
branch
from
4404db7
to
bf169fd
Compare
The cursor used on the stars of the rating component is a text selection cursor, which doesn't make it clear that they're clickable. The cursor stays the same if the rating component is readonly. This commit sets a 'pointer' cursor on the stars, and a 'not-allowed' cursor when it's read-only.
jnizet
force-pushed
the
feat/cursor-on-rating
branch
from
bf169fd
to
5b75393
Compare
|
I'm good with this approach. We might be re-visiting how stars are rendered in the future so things might change but IMO this is a good starting point. +1 from me |
|
And LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The cursor used on the stars of the rating component is a text selection cursor, which doesn't make it clear that they're clickable. The cursor stays the same if the rating component is readonly.
This commit sets a 'pointer' cursor on the stars, and a 'not-allowed' cursor when it's read-only.