fix(modal): remove visual 'twitch' when closing #4295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Twitch was caused by removing classes/styles from the `<body>` too early after `result` promise was resolved, but animation was potentially on-going. Now the cleanup is done only after BOTH `result` promise is resolved and `(hidden)` event was emitted on animation completion. Fixes ng-bootstrap#4293
maxokorokov
force-pushed
the
modal/fix/closing-scrollbar-twitch
branch
from
6e3df6b
to
935f918
Compare
maxokorokov
added a commit
that referenced
this pull request
Apr 7, 2022
Twitch was caused by removing classes/styles from the `<body>` too early after `result` promise was resolved, but animation was potentially on-going. Now the cleanup is done only after BOTH `result` promise is resolved and `(hidden)` event was emitted on animation completion. Fixes #4293
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twitch was caused by removing classes/styles from the
<body>too early afterresultpromise was resolved, but animation was potentially on-going.Now the cleanup is done only after BOTH
resultpromise is resolved and(hidden)event was emitted on animation completion.Fixes #4293