Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(positionning): add offset to match Bootstrap #4297

Merged
merged 5 commits into from
Apr 4, 2022
Merged

fix(positionning): add offset to match Bootstrap #4297

merged 5 commits into from
Apr 4, 2022

Conversation

fbasso
Copy link
Member

@fbasso fbasso commented Mar 28, 2022

Fix #4261

fbasso added a commit to fbasso/ng-bootstrap that referenced this pull request Mar 28, 2022
@fbasso
fix(positionning): add offset to match Bootstrap ng-bootstrap#4297
937d854
fbasso added a commit to fbasso/ng-bootstrap that referenced this pull request Mar 28, 2022
@fbasso
fix(positionning): add offset to match Bootstrap ng-bootstrap#4297
bd05d2f
@maxokorokov maxokorokov added this to the 12.0.2 milestone Mar 28, 2022
fbasso added a commit to fbasso/ng-bootstrap that referenced this pull request Mar 28, 2022
@fbasso
fix(positionning): add offset to match Bootstrap ng-bootstrap#4297
da8018a
maxokorokov
maxokorokov requested changes Mar 29, 2022
View reviewed changes
src/util/positioning.ts Outdated Show resolved Hide resolved
fbasso added a commit to fbasso/ng-bootstrap that referenced this pull request Mar 30, 2022
@fbasso
fix(positionning): add offset to match Bootstrap ng-bootstrap#4297
de662b5
maxokorokov
maxokorokov approved these changes Mar 30, 2022
View reviewed changes
Copy link
Member

@maxokorokov maxokorokov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@maxokorokov
Copy link
Member

As discussed:

  • added offsets for all dropdown-based components
  • fixed popover offset 12 → 8
    to match Bootstrap

@maxokorokov maxokorokov merged commit 7f636ed into ng-bootstrap:master Apr 4, 2022
maxokorokov pushed a commit that referenced this pull request Apr 4, 2022
@fbasso @maxokorokov
fix(dropdown): add offset to match Bootstrap #4297
9f2fe0d
@fbasso fbasso deleted the dropdown branch August 31, 2023 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxokorokov maxokorokov maxokorokov approved these changes

Assignees
No one assigned
Labels
component: dropdown
Projects
None yet
Milestone
12.0.2
Development

Successfully merging this pull request may close these issues.

Check BS5 data-*** styles
2 participants
@fbasso @maxokorokov